From: Denys Vlasenko Date: Wed, 28 Sep 2016 17:44:16 +0000 (+0200) Subject: ash: Remove unused EV_BACKCMD flag X-Git-Tag: 1_26_0~240 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=7ee7c6fc20d3b94c257f829dece097ff339895ee;p=oweals%2Fbusybox.git ash: Remove unused EV_BACKCMD flag The original ash defered forking commands in backquotes so builtins could be run in the same context as the shell. This behavior was controlled using the EV_BACKCMD to evaltree. Unfortunately, as Matthias Scheler noticed in 1999 (NetBSD PR/7814), the result was counterintuitive; for example, echo "`cd /`" would change the cwd. So ash 0.3.5 left out that optimization. Signed-off-by: Denys Vlasenko --- diff --git a/shell/ash.c b/shell/ash.c index ec006af7d..f395a16a9 100644 --- a/shell/ash.c +++ b/shell/ash.c @@ -8065,7 +8065,6 @@ static char *funcstring; /* block to allocate strings from */ /* flags in argument to evaltree */ #define EV_EXIT 01 /* exit after evaluating tree */ #define EV_TESTED 02 /* exit status is checked; ignore -e flag */ -#define EV_BACKCMD 04 /* command executing within back quotes */ static const uint8_t nodesize[N_NUMBER] ALIGN1 = { [NCMD ] = SHELL_ALIGN(sizeof(struct ncmd)),