From: Pauli <paul.dale@oracle.com>
Date: Sun, 1 Sep 2019 23:12:53 +0000 (+1000)
Subject: Fix Coverity 1453452: Control flow issues (DEADCODE)
X-Git-Tag: openssl-3.0.0-alpha1~1510
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=7964e3709af59675795ab1f4f69a935980379a66;p=oweals%2Fopenssl.git

Fix Coverity 1453452: Control flow issues (DEADCODE)

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9749)
---

diff --git a/apps/provider.c b/apps/provider.c
index 932bc40931..fe5ca1d1f7 100644
--- a/apps/provider.c
+++ b/apps/provider.c
@@ -165,8 +165,7 @@ int provider_main(int argc, char **argv)
     prog = opt_init(argc, argv, provider_options);
     while ((o = opt_next()) != OPT_EOF) {
         switch (o) {
-        case OPT_EOF:
-        case OPT_ERR:
+        default: /* Catching OPT_ERR & covering OPT_EOF which isn't possible */
             BIO_printf(bio_err, "%s: Use -help for summary.\n", prog);
             goto end;
         case OPT_HELP: