From: Matteo Croce Date: Tue, 23 Oct 2007 15:45:54 +0000 (+0000) Subject: ar7_gpio: remove unneeded checks and volatile X-Git-Tag: reboot~27746 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=788a010131706f80582e9577d2fa43fb8b33e22b;p=oweals%2Fopenwrt.git ar7_gpio: remove unneeded checks and volatile SVN-Revision: 9419 --- diff --git a/target/linux/ar7/files/include/asm-mips/ar7/gpio.h b/target/linux/ar7/files/include/asm-mips/ar7/gpio.h index a7ae1eeae1..2e19fcae9d 100644 --- a/target/linux/ar7/files/include/asm-mips/ar7/gpio.h +++ b/target/linux/ar7/files/include/asm-mips/ar7/gpio.h @@ -31,20 +31,14 @@ static inline int gpio_get_value(unsigned gpio) void __iomem *gpio_in = (void __iomem *)KSEG1ADDR(AR7_REGS_GPIO + AR7_GPIO_INPUT); - if (gpio >= AR7_GPIO_MAX) - return -EINVAL; - - return ((readl(gpio_in) & (1 << gpio)) != 0); + return readl(gpio_in) & (1 << gpio); } static inline void gpio_set_value(unsigned gpio, int value) { void __iomem *gpio_out = (void __iomem *)KSEG1ADDR(AR7_REGS_GPIO + AR7_GPIO_OUTPUT); - volatile unsigned tmp; - - if (gpio >= AR7_GPIO_MAX) - return; + unsigned tmp; tmp = readl(gpio_out) & ~(1 << gpio); if (value) @@ -95,9 +89,6 @@ static inline int ar7_gpio_enable(unsigned gpio) void __iomem *gpio_en = (void __iomem *)KSEG1ADDR(AR7_REGS_GPIO + AR7_GPIO_ENABLE); - if (gpio >= AR7_GPIO_MAX) - return -EINVAL; - writel(readl(gpio_en) | (1 << gpio), gpio_en); return 0; @@ -108,9 +99,6 @@ static inline int ar7_gpio_disable(unsigned gpio) void __iomem *gpio_en = (void __iomem *)KSEG1ADDR(AR7_REGS_GPIO + AR7_GPIO_ENABLE); - if (gpio >= AR7_GPIO_MAX) - return -EINVAL; - writel(readl(gpio_en) & ~(1 << gpio), gpio_en); return 0;