From: Petr Štetiar <ynezz@true.cz>
Date: Mon, 4 Nov 2019 23:28:15 +0000 (+0100)
Subject: cli: remove unused variable assigment
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=7736f497d2d9a43cd36526c8d8a12718eff2e6c7;p=oweals%2Fuci.git

cli: remove unused variable assigment

scan-build from clang version 9 has reported following issue:

 cli.c:574:8: warning: Although the value stored to 'ret' is used in the enclosing expression, the value is never actually read from 'ret'
                if ((ret = uci_parse_argument(ctx, input, &str, &argv[i])) != UCI_OK) {
                     ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---

diff --git a/cli.c b/cli.c
index 1ce4d5e..8970f4f 100644
--- a/cli.c
+++ b/cli.c
@@ -571,7 +571,7 @@ static int uci_batch_cmd(void)
 			return 1;
 		}
 		argv[i] = NULL;
-		if ((ret = uci_parse_argument(ctx, input, &str, &argv[i])) != UCI_OK) {
+		if (uci_parse_argument(ctx, input, &str, &argv[i]) != UCI_OK) {
 			cli_perror();
 			i = 0;
 			break;