From: Matt Caswell <matt@openssl.org>
Date: Tue, 26 Jun 2018 14:21:09 +0000 (+0100)
Subject: Remove a memset
X-Git-Tag: OpenSSL_1_1_1-pre9~183
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=74bfb980377f43367035959a2c0afb5ec501c033;p=oweals%2Fopenssl.git

Remove a memset

Also avoids calling EVP_MD_size() and a missing negative result check.

Issue found by Coverity.

Reviewed-by: Andy Polyakov <appro@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6592)
---

diff --git a/crypto/sm2/sm2_za.c b/crypto/sm2/sm2_za.c
index 94d0dac02f..8f45082db4 100644
--- a/crypto/sm2/sm2_za.c
+++ b/crypto/sm2/sm2_za.c
@@ -59,8 +59,6 @@ int sm2_compute_userid_digest(uint8_t *out,
         goto done;
     }
 
-    memset(out, 0, EVP_MD_size(digest));
-
     if (!EVP_DigestInit(hash, digest)) {
         SM2err(SM2_F_SM2_COMPUTE_USERID_DIGEST, ERR_R_EVP_LIB);
         goto done;