From: Kahrl <kahrl@gmx.net>
Date: Fri, 22 Nov 2013 23:30:16 +0000 (+0100)
Subject: Fix crash when pressing Enter key in formspec menu
X-Git-Tag: 0.4.8~22
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=6f851c969251895efc3c3f02650456a2eac05d95;p=oweals%2Fminetest.git

Fix crash when pressing Enter key in formspec menu
---

diff --git a/src/guiFormSpecMenu.cpp b/src/guiFormSpecMenu.cpp
index 2416e4c8a..8ffddcbc6 100644
--- a/src/guiFormSpecMenu.cpp
+++ b/src/guiFormSpecMenu.cpp
@@ -2297,12 +2297,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
 			switch (event.KeyInput.Key) {
 				case KEY_RETURN:
-					if (m_allowclose) {
-						acceptInput(true);
-						quitMenu();
-					}
-					else
-						current_keys_pending.key_enter = true;
+					current_keys_pending.key_enter = true;
 					break;
 				case KEY_UP:
 					current_keys_pending.key_up = true;
@@ -2316,7 +2311,13 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 					assert("reached a source line that can't ever been reached" == 0);
 					break;
 			}
-			acceptInput();
+			if (current_keys_pending.key_enter && m_allowclose) {
+				acceptInput(true);
+				quitMenu();
+			}
+			else {
+				acceptInput();
+			}
 			return true;
 		}