From: Pauli <paul.dale@oracle.com>
Date: Sun, 26 Apr 2020 23:25:42 +0000 (+1000)
Subject: coverity 1462576 Resource leak
X-Git-Tag: openssl-3.0.0-alpha2~111
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=6f0bdf41a34d21a0a7abf154c2a454fb5437251e;p=oweals%2Fopenssl.git

coverity 1462576 Resource leak

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/11651)
---

diff --git a/crypto/ec/ecx_meth.c b/crypto/ec/ecx_meth.c
index d23fcd42b7..a9c71f33aa 100644
--- a/crypto/ec/ecx_meth.c
+++ b/crypto/ec/ecx_meth.c
@@ -95,7 +95,7 @@ static int ecx_key_op(EVP_PKEY *pkey, int id, const X509_ALGOR *palg,
         case EVP_PKEY_ED25519:
             if (!ED25519_public_from_private(libctx, pubkey, privkey)) {
                 ECerr(EC_F_ECX_KEY_OP, EC_R_FAILED_MAKING_PUBLIC_KEY);
-                return 0;
+                goto err;
             }
             break;
         case EVP_PKEY_X448:
@@ -104,7 +104,7 @@ static int ecx_key_op(EVP_PKEY *pkey, int id, const X509_ALGOR *palg,
         case EVP_PKEY_ED448:
             if (!ED448_public_from_private(libctx, pubkey, privkey)) {
                 ECerr(EC_F_ECX_KEY_OP, EC_R_FAILED_MAKING_PUBLIC_KEY);
-                return 0;
+                goto err;
             }
             break;
         }