From: Jo-Philipp Wich <jo@mein.io>
Date: Mon, 23 Jul 2018 12:31:40 +0000 (+0200)
Subject: luci-base: cbi.js: use adjacent button dynlist add/remove buttons
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=6cf7d11e1598d6b23a7ad0f8155be8082a284226;p=oweals%2Fluci.git

luci-base: cbi.js: use adjacent button dynlist add/remove buttons

Change the cbi.js code to create  a div based button element instead of an
image button.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 875b561875cb4eca4c913c69ce2dfd21265b6ac6)
---

diff --git a/modules/luci-base/htdocs/luci-static/resources/cbi.js b/modules/luci-base/htdocs/luci-static/resources/cbi.js
index 89dfac9e4..9d79b81c1 100644
--- a/modules/luci-base/htdocs/luci-static/resources/cbi.js
+++ b/modules/luci-base/htdocs/luci-static/resources/cbi.js
@@ -818,9 +818,9 @@ function cbi_dynlist_init(parent, datatype, optional, choices)
 				t.placeholder = holder;
 			}
 
-			var b = document.createElement('img');
-				b.src = cbi_strings.path.resource + ((i+1) < values.length ? '/cbi/remove.gif' : '/cbi/add.gif');
-				b.className = 'cbi-image-button';
+			var b = E('div', {
+				class: 'cbi-button cbi-button-' + ((i+1) < values.length ? 'remove' : 'add')
+			}, (i+1) < values.length ? '×' : '+');
 
 			parent.appendChild(t);
 			parent.appendChild(b);
@@ -986,8 +986,7 @@ function cbi_dynlist_init(parent, datatype, optional, choices)
 			input = input.previousSibling;
 		}
 
-		if (se.src.indexOf('remove') > -1)
-		{
+		if (se.classList.contains('cbi-button-remove')) {
 			input.value = '';
 
 			cbi_dynlist_keydown({
@@ -995,8 +994,7 @@ function cbi_dynlist_init(parent, datatype, optional, choices)
 				keyCode: 8
 			});
 		}
-		else
-		{
+		else {
 			cbi_dynlist_keydown({
 				target:  input,
 				keyCode: 13