From: Nikita Kiryanov <nikita@compulab.co.il>
Date: Wed, 14 Jan 2015 08:42:49 +0000 (+0200)
Subject: compulab: splash: use errno values
X-Git-Tag: v2015.04-rc2~35^2~16
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=6947e3f56f265c9bb1f3832c74630adf6286987d;p=oweals%2Fu-boot.git

compulab: splash: use errno values

Use errno values to improve return reporting.

Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Igor Grinberg <grinberg@compulab.co.il>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
---

diff --git a/board/compulab/common/splash.c b/board/compulab/common/splash.c
index 49ed49b81e..33b2f9f570 100644
--- a/board/compulab/common/splash.c
+++ b/board/compulab/common/splash.c
@@ -8,6 +8,7 @@
 
 #include <common.h>
 #include <nand.h>
+#include <errno.h>
 #include <bmp_layout.h>
 
 DECLARE_GLOBAL_DATA_PTR;
@@ -44,12 +45,12 @@ splash_address_too_high:
 	printf("Error: splashimage address too high. Data overwrites U-Boot "
 		"and/or placed beyond DRAM boundaries.\n");
 
-	return -1;
+	return -EFAULT;
 }
 #else
 static inline int splash_load_from_nand(u32 bmp_load_addr, int nand_offset)
 {
-	return -1;
+	return -ENOSYS;
 }
 #endif /* CONFIG_CMD_NAND */
 
@@ -60,12 +61,12 @@ int cl_splash_screen_prepare(int nand_offset)
 
 	env_splashimage_value = getenv("splashimage");
 	if (env_splashimage_value == NULL)
-		return -1;
+		return -ENOENT;
 
 	bmp_load_addr = simple_strtoul(env_splashimage_value, 0, 16);
 	if (bmp_load_addr == 0) {
 		printf("Error: bad splashimage address specified\n");
-		return -1;
+		return -EFAULT;
 	}
 
 	return splash_load_from_nand(bmp_load_addr, nand_offset);