From: Rich Felker <dalias@aerifal.cx>
Date: Tue, 29 Aug 2017 23:39:03 +0000 (-0400)
Subject: fix unsynchronized access to FILE structure in fflush(0)
X-Git-Tag: v1.1.17~29
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=670d6d01f53b4e85be6b333bf8a137e2be6d3fc3;p=oweals%2Fmusl.git

fix unsynchronized access to FILE structure in fflush(0)

commit c002668eb0352e619ea7064e4940b397b4a6e68d inadvertently moved
the check for unflushed write buffer outside of the scope of the
existing lock.
---

diff --git a/src/stdio/fflush.c b/src/stdio/fflush.c
index c2881065..bf1e8437 100644
--- a/src/stdio/fflush.c
+++ b/src/stdio/fflush.c
@@ -9,8 +9,11 @@ int fflush(FILE *f)
 	if (!f) {
 		int r = __stdout_used ? fflush(__stdout_used) : 0;
 
-		for (f=*__ofl_lock(); f; f=f->next)
+		for (f=*__ofl_lock(); f; f=f->next) {
+			FLOCK(f);
 			if (f->wpos > f->wbase) r |= fflush(f);
+			FUNLOCK(f);
+		}
 		__ofl_unlock();
 
 		return r;