From: Dr. Stephen Henson <steve@openssl.org>
Date: Tue, 18 Mar 2014 14:19:22 +0000 (+0000)
Subject: Check return value of ssl3_output_cert_chain
X-Git-Tag: master-post-reformat~891
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=66f96fe2d519147097c118d4bf60704c69ed0635;p=oweals%2Fopenssl.git

Check return value of ssl3_output_cert_chain
---

diff --git a/ssl/s3_clnt.c b/ssl/s3_clnt.c
index 70c6533268..efc3710abd 100644
--- a/ssl/s3_clnt.c
+++ b/ssl/s3_clnt.c
@@ -3380,8 +3380,13 @@ int ssl3_send_client_certificate(SSL *s)
 	if (s->state == SSL3_ST_CW_CERT_C)
 		{
 		s->state=SSL3_ST_CW_CERT_D;
-		ssl3_output_cert_chain(s,
-			(s->s3->tmp.cert_req == 2)?NULL:s->cert->key);
+		if (!ssl3_output_cert_chain(s,
+			(s->s3->tmp.cert_req == 2)?NULL:s->cert->key))
+			{
+			SSLerr(SSL_F_SSL3_SEND_CLIENT_CERTIFICATE, ERR_R_INTERNAL_ERROR);
+			ssl3_send_alert(s,SSL3_AL_FATAL,SSL_AD_INTERNAL_ERROR);
+			return 0;
+			}
 		}
 	/* SSL3_ST_CW_CERT_D */
 	return ssl_do_write(s);
diff --git a/ssl/s3_srvr.c b/ssl/s3_srvr.c
index f048b76dca..411b6f6af8 100644
--- a/ssl/s3_srvr.c
+++ b/ssl/s3_srvr.c
@@ -3476,7 +3476,11 @@ int ssl3_send_server_certificate(SSL *s)
 				}
 			}
 
-		ssl3_output_cert_chain(s,cpk);
+		if (!ssl3_output_cert_chain(s,cpk))
+			{
+			SSLerr(SSL_F_SSL3_SEND_SERVER_CERTIFICATE,ERR_R_INTERNAL_ERROR);
+			return(0);
+			}
 		s->state=SSL3_ST_SW_CERT_B;
 		}