From: Florian Dold <florian.dold@gmail.com>
Date: Thu, 28 Feb 2019 14:40:36 +0000 (+0100)
Subject: Be explicit about truncation to silence warning.
X-Git-Tag: v0.11.1~219
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=66bc78945b25884c422139638117980aa256335f;p=oweals%2Fgnunet.git

Be explicit about truncation to silence warning.

Newer GCCs do not like truncation and emit a warning.  We don't want to
disable truncation warnings (-Wnostringop-truncation), as in some cases
these warnings can point to a security flaw.

Using strcat instead of strncat is fine, since *both* equally overflow
the destination buffer if not used carefully.

See https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/
---

diff --git a/src/util/network.c b/src/util/network.c
index a100be375..c236292b7 100644
--- a/src/util/network.c
+++ b/src/util/network.c
@@ -141,7 +141,8 @@ GNUNET_NETWORK_shorten_unixpath (char *unixpath)
     *end = '\0';
   }
   GNUNET_CRYPTO_hash_to_enc (&sh, &ae);
-  strncat (unixpath, (char *) ae.encoding, 16);
+  ae.encoding[16] = '\0';
+  strcat (unixpath, (char *) ae.encoding);
   return unixpath;
 }