From: Schanzenbach, Martin <mschanzenbach@posteo.de>
Date: Thu, 17 Oct 2019 15:07:05 +0000 (+0200)
Subject: some comments
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=65f664f17fc54c43e7bcb23fe05f3609734f8b0e;p=oweals%2Fgnunet.git

some comments
---

diff --git a/src/include/gnunet_reclaim_attribute_lib.h b/src/include/gnunet_reclaim_attribute_lib.h
index c23b39383..1fa97dcc4 100644
--- a/src/include/gnunet_reclaim_attribute_lib.h
+++ b/src/include/gnunet_reclaim_attribute_lib.h
@@ -348,6 +348,12 @@ GNUNET_RECLAIM_ATTRIBUTE_number_to_typename (uint32_t type);
 
 /**
    * Get required size for serialization buffer
+   * FIXME:
+   * 1. The naming convention is violated here.
+   * It should GNUNET_RECLAIM_ATTRIBUTE_<lowercase from here>.
+   * It might make sense to refactor attestations into a separate folder.
+   * 2. The struct should be called GNUNET_RECLAIM_ATTESTATION_Data or
+   * GNUNET_RECLAIM_ATTRIBUTE_Attestation depending on location in source.
    *
    * @param attr the attestation to serialize
    * @return the required buffer size
diff --git a/src/include/gnunet_reclaim_attribute_plugin.h b/src/include/gnunet_reclaim_attribute_plugin.h
index bdd815dcf..e61cca5b2 100644
--- a/src/include/gnunet_reclaim_attribute_plugin.h
+++ b/src/include/gnunet_reclaim_attribute_plugin.h
@@ -136,8 +136,14 @@ struct GNUNET_RECLAIM_ATTRIBUTE_PluginFunctions
   GNUNET_RECLAIM_ATTRIBUTE_NumberToTypenameFunction number_to_typename;
 
   /**
-* Attestation Conversion to string.
-*/
+   * FIXME: It is odd that attestation functions are withing the attribute
+   * plugin. An attribute type may be backed by an attestation, but not
+   * necessarily.
+   * Maybe it would make more sense to refactor this into an attestation
+   * plugin?
+   *
+   * Attestation Conversion to string.
+   */
   GNUNET_RECLAIM_ATTRIBUTE_ValueToStringFunction value_to_string_attest;
 
   /**