From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Fri, 10 May 2019 17:55:53 +0000 (+0200)
Subject: efi_loader: superfluous check in efi_remove_protocol()
X-Git-Tag: v2019.07-rc2~3^2~9
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=61c63db7fe8af569229cb598b018c65f9ad9c95f;p=oweals%2Fu-boot.git

efi_loader: superfluous check in efi_remove_protocol()

efi_search_protocol() already checks that the GUID matches. Don't check
a second time.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index 50c5374e5f..b8589b9531 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -513,8 +513,6 @@ efi_status_t efi_remove_protocol(const efi_handle_t handle,
 	ret = efi_search_protocol(handle, protocol, &handler);
 	if (ret != EFI_SUCCESS)
 		return ret;
-	if (guidcmp(handler->guid, protocol))
-		return EFI_INVALID_PARAMETER;
 	if (handler->protocol_interface != protocol_interface)
 		return EFI_INVALID_PARAMETER;
 	list_del(&handler->link);