From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Date: Mon, 2 Jun 2008 19:23:47 +0000 (-0000)
Subject: - add FIXME. Perhaps somebody is interrested in looking into this one.
X-Git-Tag: 1_11_0~135
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=6075b2aee08f0ed6e4380c28e8f5152a52fad773;p=oweals%2Fbusybox.git

- add FIXME. Perhaps somebody is interrested in looking into this one.
  We would try to be clever and compare the *data instead of the *elt.

Somethink like this might be of more general use:
/* Unlink arbitrary element from the list that contains data */
void llist_unlink_data(llist_t **head, void *data)
{
    llist_t *elt;

    for (elt = *head; elt; elt = elt->link) {
        if (elt->data == data) {
            llist_unlink(elt);
            return;
        }
    }
}
---

diff --git a/modutils/depmod.c b/modutils/depmod.c
index 09d31f4c0..733cd95bf 100644
--- a/modutils/depmod.c
+++ b/modutils/depmod.c
@@ -221,7 +221,7 @@ int depmod_main(int ATTRIBUTE_UNUSED argc, char **argv)
 				if (!strcmp(all->name, deps->data)) {
 					llist_t *implied = all->dependencies;
 					while (implied) {
-						/* erm, nicer would be to just
+						/* XXX:FIXME: erm, it would be nicer to just
 						 * llist_unlink(&mods->dependencies, implied)  */
 						llist_t *prune = mods->dependencies;
 						while (prune) {