From: Marek Vasut Date: Tue, 7 Aug 2018 10:24:35 +0000 (+0200) Subject: phy: Fix off-by-one error when parsing DT PHY bindings X-Git-Tag: v2018.09-rc3~58^2~2 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=5e50adf6679831bc34a567a1bf20ff1642c418dd;p=oweals%2Fu-boot.git phy: Fix off-by-one error when parsing DT PHY bindings The code fails to copy the last PHY phandle argument, so it is missing from the adjusted phandle args and the consumer cannot use it to determine what the PHY should do. Signed-off-by: Marek Vasut Cc: Patrice Chotard --- diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c index 6162395e75..a0ac30aa71 100644 --- a/drivers/phy/phy-uclass.c +++ b/drivers/phy/phy-uclass.c @@ -64,7 +64,7 @@ int generic_phy_get_by_index(struct udevice *dev, int index, return ret; /* insert phy idx at first position into args array */ - for (i = args.args_count; i > 1 ; i--) + for (i = args.args_count; i >= 1 ; i--) args.args[i] = args.args[i - 1]; args.args_count++;