From: Aashil Patel Date: Thu, 1 Jun 2017 00:05:14 +0000 (-0400) Subject: Remove unnecessary if condition from apps.c X-Git-Tag: OpenSSL_1_1_1-pre1~1400 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=5e44201bc5b027d3d4e2f8904719fd69ed47e515;p=oweals%2Fopenssl.git Remove unnecessary if condition from apps.c Reviewed-by: Andy Polyakov Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/3596) --- diff --git a/apps/apps.c b/apps/apps.c index c66b89cff4..1a1b7ec309 100644 --- a/apps/apps.c +++ b/apps/apps.c @@ -301,9 +301,9 @@ int password_callback(char *buf, int bufsiz, int verify, PW_CB_DATA *cb_tmp) /* We know that there is no previous user data to return to us */ (void)UI_add_user_data(ui, cb_data); - if (ok >= 0) - ok = UI_add_input_string(ui, prompt, ui_flags, buf, - PW_MIN_LENGTH, bufsiz - 1); + ok = UI_add_input_string(ui, prompt, ui_flags, buf, + PW_MIN_LENGTH, bufsiz - 1); + if (ok >= 0 && verify) { buff = app_malloc(bufsiz, "password buffer"); ok = UI_add_verify_string(ui, prompt, ui_flags, buff,