From: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Date: Mon, 19 Nov 2007 11:27:04 +0000 (+0900)
Subject: net/eth.c: Fix env_enetaddr signed overflow
X-Git-Tag: v1.3.2-rc1~100^2~33^2~43
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=5ca2d0953e4579a80810966cca2077e20d912c97;p=oweals%2Fu-boot.git

net/eth.c: Fix env_enetaddr signed overflow

Assigning the output of simple_strtoul(CB:A9:87:65:43:21) to `char', we are
warned as below:

  U-Boot 1.2.0 (Aug 30 2007 - 08:27:37)

  DRAM:  256 MB
  Flash: 32 MB
  In:    serial
  Out:   serial
  Err:   serial
  Net:   NEC-Candy
  Warning: NEC-Candy MAC addresses don't match:
  Address in SROM is         00:00:4C:80:92:A2
  Address in environment is  FFFFFFCB:FFFFFFA9:FFFFFF87:65:43:21

This patch changes env_enetaddr type from `char' to `unsigned char'.

Cc: Masaki Ishikawa <ishikawa-masaki@cnt.mxe.nes.nec.co.jp>
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
---

diff --git a/net/eth.c b/net/eth.c
index 4657f7970f..425f29edba 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -149,7 +149,8 @@ int eth_register(struct eth_device* dev)
 
 int eth_initialize(bd_t *bis)
 {
-	char enetvar[32], env_enetaddr[6];
+	char enetvar[32];
+	unsigned char env_enetaddr[6];
 	int i, eth_number = 0;
 	char *tmp, *end;