From: Hans de Goede <hdegoede@redhat.com>
Date: Fri, 29 May 2015 13:09:48 +0000 (+0200)
Subject: image-fit: Fix compiler warning in fit_conf_print()
X-Git-Tag: v2015.07-rc2~7
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=5bcec545a6ca977ad74ee9fe0f2b335d348b5000;p=oweals%2Fu-boot.git

image-fit: Fix compiler warning in fit_conf_print()

This fixes the following compiler warning:

In file included from tools/common/image-fit.c:1:0:
./tools/../common/image-fit.c: In function ‘fit_conf_print’:
./tools/../common/image-fit.c:1470:27: warning: logical not is only applied
 to the left hand side of comparison [-Wlogical-not-parentheses]
    (const char **)&uname) > 0;

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---

diff --git a/common/image-fit.c b/common/image-fit.c
index 4bd8feaf3b..28f7aa83ba 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -1464,10 +1464,10 @@ void fit_conf_print(const void *fit, int noffset, const char *p)
 
 	/* Print out all of the specified loadables */
 	for (loadables_index = 0;
-	     !fdt_get_string_index(fit, noffset,
+	     fdt_get_string_index(fit, noffset,
 			FIT_LOADABLE_PROP,
 			loadables_index,
-			(const char **)&uname) > 0;
+			(const char **)&uname) == 0;
 	     loadables_index++)
 	{
 		if (loadables_index == 0) {