From: Bartosz Golaszewski Date: Thu, 23 Jun 2016 15:19:50 +0000 (+0200) Subject: i2cdump: don't use common_bufsiz1 X-Git-Tag: 1_26_0~336 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=59f81976249a85cf02bd73c2395f018033069466;p=oweals%2Fbusybox.git i2cdump: don't use common_bufsiz1 Commit e6a2f4cc changed the way common_bufsiz1 works. Now it needs to be initialized before using, but i2cdump wasn't updated by said patch. Since the fact that we're using common_bufsiz1 here isn't obvious (no G_INIT() macro, no other global variables), drop it and simply allocate the integer array required for block reads on the stack. Tested with i2c block read on a Lenovo Thinkpad laptop. Signed-off-by: Bartosz Golaszewski Signed-off-by: Denys Vlasenko --- diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c index 57bb72ae7..7731466f7 100644 --- a/miscutils/i2c_tools.c +++ b/miscutils/i2c_tools.c @@ -908,7 +908,7 @@ int i2cdump_main(int argc UNUSED_PARAM, char **argv) int bus_num, bus_addr, mode = I2C_SMBUS_BYTE_DATA, even = 0, pec = 0; unsigned first = 0x00, last = 0xff, opts; - int *block = (int *)bb_common_bufsiz1; + int block[I2CDUMP_NUM_REGS]; char *opt_r_str, *dash; int fd, res;