From: Richard Levitte Date: Sun, 6 Aug 2000 01:35:03 +0000 (+0000) Subject: For n > 7, we might get uninitialized (unzeroed) data. X-Git-Tag: OpenSSL-engine-0_9_6-beta1~12^2~74 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=5584fa1709585ee6d7e4f20551a71077f0e36699;p=oweals%2Fopenssl.git For n > 7, we might get uninitialized (unzeroed) data. Spotted by "Kyoungho Jeon" . --- diff --git a/crypto/asn1/a_bitstr.c b/crypto/asn1/a_bitstr.c index c0501e1ea9..7013a407ad 100644 --- a/crypto/asn1/a_bitstr.c +++ b/crypto/asn1/a_bitstr.c @@ -236,10 +236,10 @@ int ASN1_BIT_STRING_set_bit(ASN1_BIT_STRING *a, int n, int value) else c=(unsigned char *)OPENSSL_realloc(a->data,w+1); if (c == NULL) return(0); + if (w+1-a->length > 0) memset(c+a->length, 0, w+1-a->length); a->data=c; a->length=w+1; - c[w]=0; - } + } a->data[w]=((a->data[w])&iv)|v; while ((a->length > 0) && (a->data[a->length-1] == 0)) a->length--;