From: Rob Landley <rob@landley.net>
Date: Sun, 18 Dec 2005 20:34:41 +0000 (-0000)
Subject: strncmp isn't automatically superior to strcmp.  Especially when it isn't
X-Git-Tag: 1_1_0~399
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=553d83d427741a13e7e66be0aa903c3edceb5823;p=oweals%2Fbusybox.git

strncmp isn't automatically superior to strcmp.  Especially when it isn't
used right.
---

diff --git a/loginutils/vlock.c b/loginutils/vlock.c
index b66a3b1ae..b15b0ace0 100644
--- a/loginutils/vlock.c
+++ b/loginutils/vlock.c
@@ -101,7 +101,7 @@ extern int vlock_main(int argc, char **argv)
 	}
 
 	if (argc == 2) {
-		if (strncmp(argv[1], "-a", 2)) {
+		if (strcmp(argv[1], "-a")) {
 			bb_show_usage();
 		} else {
 			o_lock_all = 1;
@@ -199,7 +199,7 @@ extern int vlock_main(int argc, char **argv)
 		}
 
 		crypt_pass = pw_encrypt(pass, pw->pw_passwd);
-		if (strncmp(crypt_pass, pw->pw_passwd, sizeof(crypt_pass)) == 0) {
+		if (strcmp(crypt_pass, pw->pw_passwd) == 0) {
 			memset(pass, 0, strlen(pass));
 			memset(crypt_pass, 0, strlen(crypt_pass));
 			restore_terminal();