From: Richard Levitte <levitte@openssl.org>
Date: Sun, 24 Jun 2001 07:00:41 +0000 (+0000)
Subject: Make sure we don't return 0 on error.
X-Git-Tag: OpenSSL_0_9_6c~182^2~72
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=54c7559a7e2e3568923adfb7138e5645e3275932;p=oweals%2Fopenssl.git

Make sure we don't return 0 on error.
---

diff --git a/crypto/ui/ui_lib.c b/crypto/ui/ui_lib.c
index 2559ea54b6..932658e2b7 100644
--- a/crypto/ui/ui_lib.c
+++ b/crypto/ui/ui_lib.c
@@ -176,6 +176,8 @@ static int general_allocate_string(UI *ui, const char *prompt,
 			s->_.string_data.result_maxsize=maxsize;
 			s->_.string_data.test_buf=test_buf;
 			ret=sk_UI_STRING_push(ui->strings, s);
+			/* sk_push() returns 0 on error.  Let's addapt that */
+			if (ret <= 0) ret--;
 			}
 		else
 			free_string(s);
@@ -223,6 +225,9 @@ static int general_allocate_boolean(UI *ui,
 				s->_.boolean_data.ok_chars = ok_chars;
 				s->_.boolean_data.cancel_chars = cancel_chars;
 				ret=sk_UI_STRING_push(ui->strings, s);
+				/* sk_push() returns 0 on error.
+				   Let's addapt that */
+				if (ret <= 0) ret--;
 				}
 			else
 				free_string(s);