From: Bernd Edlinger <bernd.edlinger@hotmail.de>
Date: Sun, 17 Mar 2019 16:28:24 +0000 (+0100)
Subject: Clear the point S before freeing in ec_mul_consttime
X-Git-Tag: OpenSSL_1_1_0k~7
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=502b871ad4eacc96a31f89d9a9470ca2858da998;p=oweals%2Fopenssl.git

Clear the point S before freeing in ec_mul_consttime

The secret point R can be recovered from S using the equation R = S - P.
The X and Z coordinates should be sufficient for that.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/8505)
---

diff --git a/crypto/ec/ec_mult.c b/crypto/ec/ec_mult.c
index 8350082eb4..47c0fc028c 100644
--- a/crypto/ec/ec_mult.c
+++ b/crypto/ec/ec_mult.c
@@ -325,7 +325,7 @@ static int ec_mul_consttime(const EC_GROUP *group, EC_POINT *r,
     ret = 1;
 
  err:
-    EC_POINT_free(s);
+    EC_POINT_clear_free(s);
     BN_CTX_end(ctx);
     BN_CTX_free(new_ctx);