From: J Mohan Rao Arisankala <mohan@barracuda.com>
Date: Wed, 24 Feb 2016 00:30:48 +0000 (+0530)
Subject: explicit check for NULL
X-Git-Tag: OpenSSL_1_1_0-pre4~500
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=4f25aecd7599842205b135c0731b20a3c2c5d97b;p=oweals%2Fopenssl.git

explicit check for NULL

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
---

diff --git a/crypto/asn1/a_sign.c b/crypto/asn1/a_sign.c
index 6e6f497880..dbf2812d6f 100644
--- a/crypto/asn1/a_sign.c
+++ b/crypto/asn1/a_sign.c
@@ -243,12 +243,12 @@ int ASN1_item_sign_ctx(const ASN1_ITEM *it,
     type = EVP_MD_CTX_md(ctx);
     pkey = EVP_PKEY_CTX_get0_pkey(EVP_MD_CTX_pkey_ctx(ctx));
 
-    if (!type || !pkey) {
+    if (NULL == type || NULL == pkey) {
         ASN1err(ASN1_F_ASN1_ITEM_SIGN_CTX, ASN1_R_CONTEXT_NOT_INITIALISED);
         goto err;
     }
 
-    if (!pkey->ameth) {
+    if (NULL == pkey->ameth) {
         ASN1err(ASN1_F_ASN1_ITEM_SIGN_CTX, ASN1_R_DIGEST_AND_KEY_TYPE_NOT_SUPPORTED);
         goto err;
     }