From: Steven Barth <steven@midlink.org>
Date: Tue, 29 Jul 2014 16:43:45 +0000 (+0200)
Subject: add_dynamic: remove redundant code
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=4bf89afc22b43d5bd155d32d3998348a77179c1a;p=oweals%2Fnetifd.git

add_dynamic: remove redundant code

device_config is unneeded since add_dynamic is used to create aliases
checking of setup state is unneeded because of race condition fixes

Signed-off-by: Steven Barth <steven@midlink.org>
---

diff --git a/ubus.c b/ubus.c
index bed1fa4..2522cfa 100644
--- a/ubus.c
+++ b/ubus.c
@@ -140,8 +140,6 @@ netifd_add_dynamic(struct ubus_context *ctx, struct ubus_object *obj,
 	if (!iface)
 		return UBUS_STATUS_UNKNOWN_ERROR;
 
-	iface->device_config = true;
-
 	config = blob_memdup(msg);
 	if (!config)
 		goto error;
@@ -161,11 +159,6 @@ netifd_add_dynamic(struct ubus_context *ctx, struct ubus_object *obj,
 	if (!dev || !dev->default_config)
 		return UBUS_STATUS_UNKNOWN_ERROR;
 
-	device_set_config(dev, dev->type, msg);
-
-	if (iface->state != IFS_SETUP && iface->state != IFS_UP)
-		vlist_delete(&interfaces, &iface->node);
-
 	return UBUS_STATUS_OK;
 
 error: