From: Christian Grothoff <christian@grothoff.org>
Date: Mon, 18 Jan 2010 16:34:30 +0000 (+0000)
Subject: fixed
X-Git-Tag: initial-import-from-subversion-38251~22932
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=4affb8454c8c141e5f968db30a76365b12594b8f;p=oweals%2Fgnunet.git

fixed
---

diff --git a/TODO b/TODO
index ab1d96172..156910858 100644
--- a/TODO
+++ b/TODO
@@ -13,24 +13,6 @@ away), in order in which they will likely be done:
 
 Urgent items (before announcing ng.gnunet.org):
 * topology
-  - valgrind crash (in topology test case):
-==31107== Invalid read of size 8                                                                                                             
-==31107==    at 0x401DA1: free_peer (gnunet-daemon-topology.c:480)                                                                           
-==31107==    by 0x4030A2: cleaning_task (gnunet-daemon-topology.c:1212)                                                                      
-==31107==    by 0x545DCBD: run_ready (scheduler.c:482)                                                                                       
-==31107==    by 0x545E0CD: GNUNET_SCHEDULER_run (scheduler.c:609)                                                                            
-==31107==    by 0x545B00F: GNUNET_PROGRAM_run (program.c:223)                                                                                
-==31107==    by 0x403477: main (gnunet-daemon-topology.c:1346)                                                                               
-==31107==  Address 0x737e828 is 8 bytes inside a block of size 144 free'd                                                                    
-==31107==    at 0x4C21DBC: free (vg_replace_malloc.c:325)                                                                                    
-==31107==    by 0x544240B: GNUNET_xfree_ (common_allocation.c:144)                                                                           
-==31107==    by 0x401E13: free_peer (gnunet-daemon-topology.c:487)                                                                           
-==31107==    by 0x4030A2: cleaning_task (gnunet-daemon-topology.c:1212)                                                                      
-==31107==    by 0x545DCBD: run_ready (scheduler.c:482)                                                                                       
-==31107==    by 0x545E0CD: GNUNET_SCHEDULER_run (scheduler.c:609)                                                                            
-==31107==    by 0x545B00F: GNUNET_PROGRAM_run (program.c:223)                                                                                
-==31107==    by 0x403477: main (gnunet-daemon-topology.c:1346)                                                                               
-==31107==                                                                                                                                    
   - considers peers 'connected' well before they actually are
     (since core notifies about it too early?);
   - (forced) disconnect does not work (also CORE API issue)
diff --git a/src/core/core.h b/src/core/core.h
index efa7bf1c9..f9117ef4c 100644
--- a/src/core/core.h
+++ b/src/core/core.h
@@ -250,7 +250,7 @@ struct ConfigurationInfoMessage
 
 /**
  * Client asking core to transmit a particular message to
- * a particular target.  Does NOT have to be solicited.
+ * a particular target.  
  */
 struct SendMessage
 {
diff --git a/src/hostlist/test_gnunet_daemon_hostlist_peer1.conf b/src/hostlist/test_gnunet_daemon_hostlist_peer1.conf
index 6f19661d6..2ee203504 100644
--- a/src/hostlist/test_gnunet_daemon_hostlist_peer1.conf
+++ b/src/hostlist/test_gnunet_daemon_hostlist_peer1.conf
@@ -41,3 +41,4 @@ DEBUG = YES
 
 [topology]
 DEBUG = YES
+PREFIX = valgrind --tool=memcheck
diff --git a/src/hostlist/test_gnunet_daemon_hostlist_peer2.conf b/src/hostlist/test_gnunet_daemon_hostlist_peer2.conf
index ec34c8a8b..9e339b918 100644
--- a/src/hostlist/test_gnunet_daemon_hostlist_peer2.conf
+++ b/src/hostlist/test_gnunet_daemon_hostlist_peer2.conf
@@ -40,4 +40,5 @@ DEBUG = YES
 #BINARY = /home/grothoff/bin/gnunet-daemon-hostlist
 
 [topology]
-DEBUG = YES
\ No newline at end of file
+DEBUG = YES
+PREFIX = valgrind --tool=memcheck
diff --git a/src/topology/test_gnunet_service_topology_data.conf b/src/topology/test_gnunet_service_topology_data.conf
index a4a832e56..bedf53129 100644
--- a/src/topology/test_gnunet_service_topology_data.conf
+++ b/src/topology/test_gnunet_service_topology_data.conf
@@ -29,7 +29,7 @@ PORT = 2670
 
 [topology]
 DEBUG = YES
-PREFIX = valgrind --tool=memcheck
+#PREFIX = valgrind --tool=memcheck
 
 [testing]
 WEAKRANDOM = YES