From: Pauli <paul.dale@oracle.com>
Date: Wed, 29 Jan 2020 23:04:14 +0000 (+1000)
Subject: scrypt: free the MD reference correctly.
X-Git-Tag: openssl-3.0.0-alpha1~581
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=4a0a9e5767f23f684267eb19e412d26cb288930d;p=oweals%2Fopenssl.git

scrypt: free the MD reference correctly.

The code was calling EVP_MD_meth_free which is incorrect.  It should call
EVP_MD_free.  It happened to work but by luck rather than design.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/10973)
---

diff --git a/providers/implementations/kdfs/scrypt.c b/providers/implementations/kdfs/scrypt.c
index 425db1af6f..ea859b9150 100644
--- a/providers/implementations/kdfs/scrypt.c
+++ b/providers/implementations/kdfs/scrypt.c
@@ -75,7 +75,7 @@ static void kdf_scrypt_free(void *vctx)
     KDF_SCRYPT *ctx = (KDF_SCRYPT *)vctx;
 
     if (ctx != NULL) {
-        EVP_MD_meth_free(ctx->sha256);
+        EVP_MD_free(ctx->sha256);
         kdf_scrypt_reset(ctx);
         OPENSSL_free(ctx);
     }