From: Michal Simek <michal.simek@xilinx.com>
Date: Thu, 10 Oct 2019 09:26:16 +0000 (+0200)
Subject: firmware: zynqmp: Clean up zynqmp_power_probe
X-Git-Tag: v2020.01-rc1~8^2~71
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=44dccd592485e18f63bbbe5dc92cffb168fd9038;p=oweals%2Fu-boot.git

firmware: zynqmp: Clean up zynqmp_power_probe

Fix error debug messages to be more accurate and aligned with debug message
style in the whole file.
And do not initialize ret variable because it is initialized later on and
it is just additional step.

Fixes: 1327d1678bd2 ("firmware: zynqmp: Add zynqmp-power support")
Reported-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
---

diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c
index 4911734f6c..dea58b5581 100644
--- a/drivers/firmware/firmware-zynqmp.c
+++ b/drivers/firmware/firmware-zynqmp.c
@@ -110,19 +110,19 @@ void zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size)
 
 static int zynqmp_power_probe(struct udevice *dev)
 {
-	int ret = 0;
+	int ret;
 
 	debug("%s, (dev=%p)\n", __func__, dev);
 
 	ret = mbox_get_by_name(dev, "tx", &zynqmp_power.tx_chan);
 	if (ret) {
-		debug("%s, cannot tx mailbox\n", __func__);
+		debug("%s: Cannot find tx mailbox\n", __func__);
 		return ret;
 	}
 
 	ret = mbox_get_by_name(dev, "rx", &zynqmp_power.rx_chan);
 	if (ret) {
-		debug("%s, cannot rx mailbox\n", __func__);
+		debug("%s: Cannot find rx mailbox\n", __func__);
 		return ret;
 	}