From: Nathan S. Evans <evans@in.tum.de>
Date: Fri, 5 Mar 2010 10:54:28 +0000 (+0000)
Subject: disconnect neighbor on single failed address, wrong behavior
X-Git-Tag: initial-import-from-subversion-38251~22556
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=441d62754d26edab61ef7fd9bc5c3f6c3c59af5a;p=oweals%2Fgnunet.git

disconnect neighbor on single failed address, wrong behavior
---

diff --git a/src/transport/gnunet-service-transport.c b/src/transport/gnunet-service-transport.c
index c68af83a2..fa9d8f82b 100644
--- a/src/transport/gnunet-service-transport.c
+++ b/src/transport/gnunet-service-transport.c
@@ -829,7 +829,9 @@ static void try_transmission_to_peer (struct NeighbourList *neighbour);
  * if sender_address is not specified (NULL) then return the
  * first matching entry.  If sender_address is specified, then
  * make sure that the address and address_len also matches.
- *
+ * 
+ * FIXME: This description does not fit the function.
+ *  
  * @return NULL if not found.
  */
 static struct NeighbourList *
@@ -1095,8 +1097,10 @@ transmit_send_continuation (void *cls,
     transmit_send_ok (mq->client, n, result);
   GNUNET_free (mq);
   try_transmission_to_peer (n);
+  /** Never disconnect a neighbor here... 
   if (result != GNUNET_OK)
-    disconnect_neighbour (n, GNUNET_YES);    
+    disconnect_neighbour (n, GNUNET_YES);
+  */    
 }