From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Date: Thu, 21 Sep 2006 20:40:56 +0000 (-0000)
Subject: - silence gcc warning about a funcptr possibly being used uninitialized.
X-Git-Tag: 1_4_0~643
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=42f67026a1423247ef18cdf22669ebe4698ff7ad;p=oweals%2Fbusybox.git

- silence gcc warning about a funcptr possibly being used uninitialized.
  This is a perfect example on where we should NOT care if the functor is not
  initialized since the result will not be what the user may expect.
  Safe bet would be to init to NULL, but let's try normal uu for good measure.
- fix commentary typo while at it.
---

diff --git a/coreutils/uudecode.c b/coreutils/uudecode.c
index 2ec4306d0..b87c33dc7 100644
--- a/coreutils/uudecode.c
+++ b/coreutils/uudecode.c
@@ -36,7 +36,7 @@ static int read_stduu(FILE *src_stream, FILE *dst_stream)
 		}
 
 		line_ptr++;
-		/* Tolerate an overly long line to acomadate a possible exta '`' */
+		/* Tolerate an overly long line to accomodate a possible exta '`' */
 		if (strlen(line_ptr) < (size_t)length) {
 			bb_error_msg_and_die("Short file");
 		}
@@ -125,7 +125,7 @@ static int read_base64(FILE *src_stream, FILE *dst_stream)
 
 int uudecode_main(int argc, char **argv)
 {
-	int (*decode_fn_ptr) (FILE * src, FILE * dst);
+	int (*decode_fn_ptr)(FILE * src, FILE * dst) = read_stduu; /* silence gcc */
 	FILE *src_stream;
 	char *outname = NULL;
 	char *line;