From: Matthias Wachs <wachs@net.in.tum.de>
Date: Thu, 25 Jun 2015 08:47:00 +0000 (+0000)
Subject: adding a first set of fixmes to stun code
X-Git-Tag: initial-import-from-subversion-38251~1689
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=4047fdf6b0ab8b49b49b06df1ce54e085f660696;p=oweals%2Fgnunet.git

adding a first set of fixmes to stun code
---

diff --git a/src/nat/nat_stun.c b/src/nat/nat_stun.c
index 490a11257..085683c47 100644
--- a/src/nat/nat_stun.c
+++ b/src/nat/nat_stun.c
@@ -427,12 +427,14 @@ stun_dns_callback (void *cls,
 
      if(NULL == request) {
           LOG (GNUNET_ERROR_TYPE_INFO, "Empty request\n");
+          /* FIXME clean up ? */
           return;
      }
 
      if (NULL == addr) {
           request->dns_active = NULL;
           LOG (GNUNET_ERROR_TYPE_INFO, "Error resolving host %s\n", request->stun_server);
+          /* FIXME clean up? */
           return;
      }
 
@@ -487,6 +489,7 @@ GNUNET_NAT_stun_make_request(char * server, int port, struct GNUNET_NETWORK_Hand
         strcpy (server_copy, server);
      }else{
          GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "Failed to allocate string");
+         /* FIXME: cleanup rh? */
          return NULL;
      }
 
@@ -495,7 +498,7 @@ GNUNET_NAT_stun_make_request(char * server, int port, struct GNUNET_NETWORK_Hand
      rh->dns_active = GNUNET_RESOLVER_ip_get (rh->stun_server, AF_INET,
                                               GNUNET_CONNECTION_CONNECT_RETRY_TIMEOUT,
                                               &stun_dns_callback, rh);
-
+     /* FIXME: error handling NULL==dns_active, callback function? */
 
      return rh;
-}
\ No newline at end of file
+}