From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Tue, 5 May 2020 23:37:25 +0000 (+0200)
Subject: efi_loader: error handling in efi_set_variable_common().
X-Git-Tag: v2020.07-rc2~6^2~6
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=3fdff6be40b01423aacf2c02eb3b4ef6d2186caf;p=oweals%2Fu-boot.git

efi_loader: error handling in efi_set_variable_common().

Fix unreachable code. Free memory on error.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c
index 58f8fae358..33df52e663 100644
--- a/lib/efi_loader/efi_variable.c
+++ b/lib/efi_loader/efi_variable.c
@@ -981,7 +981,7 @@ static efi_status_t efi_set_variable_common(u16 *variable_name,
 	if (append) {
 		old_data = malloc(old_size);
 		if (!old_data) {
-			return EFI_OUT_OF_RESOURCES;
+			ret = EFI_OUT_OF_RESOURCES;
 			goto err;
 		}
 		ret = EFI_CALL(efi_get_variable(variable_name, vendor,