From: Jo-Philipp Wich <jow@openwrt.org>
Date: Fri, 16 Dec 2011 06:05:51 +0000 (+0000)
Subject: libs/web: rework hostname match to not allow arbritary sequences of numbers and dots
X-Git-Tag: 0.11.0~1224
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=375a476d27afae5c978b48a555fe32c94e2cf854;p=oweals%2Fluci.git

libs/web: rework hostname match to not allow arbritary sequences of numbers and dots
---

diff --git a/libs/web/htdocs/luci-static/resources/cbi.js b/libs/web/htdocs/luci-static/resources/cbi.js
index 8d32b669d..e932dac1d 100644
--- a/libs/web/htdocs/luci-static/resources/cbi.js
+++ b/libs/web/htdocs/luci-static/resources/cbi.js
@@ -153,8 +153,9 @@ var cbi_validators = {
 	'hostname': function(v)
 	{
 		if (v.length <= 253)
-			return (v.match(/^[a-zA-Z0-9]+$/) != null ||
-			        v.match(/^[a-zA-Z0-9][a-zA-Z0-9\-.]*[a-zA-Z0-9]$/) != null);
+			return (v.match(/^[a-zA-Z]+$/) != null ||
+			        (v.match(/^[a-zA-Z0-9][a-zA-Z0-9\-.]*[a-zA-Z0-9]$/) &&
+			         v.match(/[^0-9.]/)));
 
 		return false;
 	},
@@ -191,7 +192,7 @@ var cbi_validators = {
 	'neg_network_ip4addr': function(v)
 	{
 		v = v.replace(/^\s*!/, "");
-		return cbi_validators.uciname(v) || cbi_validators.ip4addr(v);		
+		return cbi_validators.uciname(v) || cbi_validators.ip4addr(v);
 	},
 
 	'range': function(v, args)
diff --git a/libs/web/luasrc/cbi/datatypes.lua b/libs/web/luasrc/cbi/datatypes.lua
index 9a3b73500..65a8eedeb 100644
--- a/libs/web/luasrc/cbi/datatypes.lua
+++ b/libs/web/luasrc/cbi/datatypes.lua
@@ -142,8 +142,9 @@ end
 
 function hostname(val)
 	if val and (#val < 254) and (
-	   val:match("^[a-zA-Z0-9]+$") or
-	   val:match("^[a-zA-Z0-9][a-zA-Z0-9%-%.]*[a-zA-Z0-9]$")
+	   val:match("^[a-zA-Z]+$") or
+	   (val:match("^[a-zA-Z0-9][a-zA-Z0-9%-%.]*[a-zA-Z0-9]$") and
+	    val:match("[^0-9%.]"))
 	) then
 		return true
 	end
@@ -238,7 +239,7 @@ function neg_network_ip4addr(val)
 	if type(v) == "string" then
 		v = v:gsub("^%s*!", "")
 		return (uciname(v) or ip4addr(v))
-	end	
+	end
 end
 
 function range(val, min, max)