From: Hans Dedecker <dedeckeh@gmail.com>
Date: Mon, 1 Apr 2019 11:53:50 +0000 (+0200)
Subject: proto-shell: return error in case setup fails
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=361b3e404ccf093afa58b147ff18df1b17f6016d;p=oweals%2Fnetifd.git

proto-shell: return error in case setup fails

In case PROTO_CMD_SETUP cannot be handled due to an invalid state; return
-1 so the calling functions are aware the PROTO_CMD_SETUP has failed.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
---

diff --git a/proto-shell.c b/proto-shell.c
index 9653f4c..47a9568 100644
--- a/proto-shell.c
+++ b/proto-shell.c
@@ -181,11 +181,6 @@ proto_shell_handler(struct interface_proto_state *proto,
 			state->sm = S_SETUP;
 			break;
 
-		case S_SETUP_ABORT:
-		case S_TEARDOWN:
-		case S_SETUP:
-			return 0;
-
 		default:
 			return -1;
 		}