From: Chuanhong Guo Date: Fri, 10 May 2019 14:17:28 +0000 (+0800) Subject: ath79: ag71xx: defer probe if of_phy_connect failed X-Git-Tag: v19.07.0-rc1~513 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=32817580e79bb129e5ea78285109c6119ff40fd0;p=oweals%2Fopenwrt.git ath79: ag71xx: defer probe if of_phy_connect failed gmac0 may need a phy on builtin switch, which can be unavailable if gmac0 is probed before builtin switch. Return -EPROBE_DEFER in this case so that gmac0 can be probed later. Signed-off-by: Chuanhong Guo --- diff --git a/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c b/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c index f9df38d530..ac1af26860 100644 --- a/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c +++ b/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c @@ -75,8 +75,8 @@ int ag71xx_phy_connect(struct ag71xx *ag) if (!ag->phy_dev) { dev_err(&ag->pdev->dev, - "Could not connect to PHY device\n"); - return -ENODEV; + "Could not connect to PHY device. Deferring probe.\n"); + return -EPROBE_DEFER; } dev_info(&ag->pdev->dev, "connected to PHY at %s [uid=%08x, driver=%s]\n",