From: lurchi <lurchi@strangeplace.net>
Date: Thu, 27 Jun 2019 12:37:19 +0000 (+0200)
Subject: no null byte needed in message payload, so GNUNET_memcpy fits better
X-Git-Tag: v0.11.6~63
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=32063cf3f2f09f39634dac791f4b71e4bd15cc47;p=oweals%2Fgnunet.git

no null byte needed in message payload, so GNUNET_memcpy fits better
---

diff --git a/src/testbed/testbed_api.c b/src/testbed/testbed_api.c
index 22ce7eb72..ade1a93de 100644
--- a/src/testbed/testbed_api.c
+++ b/src/testbed/testbed_api.c
@@ -2014,9 +2014,9 @@ GNUNET_TESTBED_create_helper_init_msg_ (const char *trusted_ip,
   msg->config_size = htons (config_size);
   (void) strcpy ((char *) &msg[1], trusted_ip);
   if (0 != hostname_len)
-    /* intentionally use strncpy (no null byte needed) */
-    (void) strncpy (((char *) &msg[1]) + trusted_ip_len + 1, hostname,
-                    hostname_len);
+    GNUNET_memcpy (&msg[1] + trusted_ip_len + 1,
+                   hostname,
+                   hostname_len);
   return msg;
 }