From: Loïc Blot <loic.blot@unix-experience.fr>
Date: Mon, 4 Sep 2017 15:28:29 +0000 (+0200)
Subject: Revert "Network: fix a concurrency problem, by re-adding a copy in ConnectionCommand"
X-Git-Tag: 5.0.0~857
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=31e0f0efe93a987b7d472dbece18a3d95b00fa96;p=oweals%2Fminetest.git

Revert "Network: fix a concurrency problem, by re-adding a copy in ConnectionCommand"

This reverts commit 5b04f5e7d231437b534f4cad39da78624d97c584.
---

diff --git a/src/network/connection.h b/src/network/connection.h
index 94d5aa1e9..e1bb613f0 100644
--- a/src/network/connection.h
+++ b/src/network/connection.h
@@ -330,18 +330,6 @@ struct ConnectionCommand
 	bool raw = false;
 
 	ConnectionCommand() = default;
-	ConnectionCommand &operator=(const ConnectionCommand &other)
-	{
-		type = other.type;
-		address = other.address;
-		peer_id = other.peer_id;
-		channelnum = other.channelnum;
-		// We must copy the buffer here to prevent race condition
-		data = SharedBuffer<u8>(*other.data, other.data.getSize());
-		reliable = other.reliable;
-		raw = other.reliable;
-		return *this;
-	}
 
 	void serve(Address address_)
 	{