From: Rich Salz <rsalz@openssl.org>
Date: Thu, 4 Sep 2014 16:55:31 +0000 (-0400)
Subject: RT2849: Redundant check of "dsa" variable.
X-Git-Tag: master-post-reformat~405
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=3173622ef6e8a596bf031e9b8a1eae4cd072ce03;p=oweals%2Fopenssl.git

RT2849: Redundant check of "dsa" variable.

In the current code, the check isn't redundant.
And in fact the REAL check was missing.
This avoids a NULL-deref crash.

Reviewed-by: Dr. Stephen Henson <steve@openssl.org>
---

diff --git a/fips/dsa/fips_dssvs.c b/fips/dsa/fips_dssvs.c
index e2f2297f00..6a0b40fc41 100644
--- a/fips/dsa/fips_dssvs.c
+++ b/fips/dsa/fips_dssvs.c
@@ -552,6 +552,11 @@ static void keypair(FILE *in, FILE *out)
 	    int n=atoi(value);
 
 	    dsa = FIPS_dsa_new();
+	    if (!dsa)
+		{
+		fprintf(stderr, "DSA allocation error\n");
+		exit(1);
+		}
 	    if (!dsa2 && !dsa_builtin_paramgen(dsa, L, N, NULL, NULL, 0,
 						NULL, NULL, NULL, NULL))
 			{
@@ -578,8 +583,7 @@ static void keypair(FILE *in, FILE *out)
 		do_bn_print_name(out, "Y",dsa->pub_key);
 	    	fputs(RESP_EOL, out);
 		}
-	    if (dsa)
-		FIPS_dsa_free(dsa);
+	    FIPS_dsa_free(dsa);
 	    }
 	}
     }