From: Simon Glass Date: Mon, 19 Jun 2017 04:09:04 +0000 (-0600) Subject: dtoc: Add a comment about string replace in conv_name_to_c() X-Git-Tag: v2017.09-rc1~214^2~28 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=30107b08d7df87e4c92e413d92896a847f1c74dd;p=oweals%2Fu-boot.git dtoc: Add a comment about string replace in conv_name_to_c() This function uses several separate string replaces where a regular expression might seem more reasonable. Add a comment justifying the way it is currently done. Signed-off-by: Simon Glass --- diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py index 9923892dc3..1f85343a9f 100644 --- a/tools/dtoc/dtb_platdata.py +++ b/tools/dtoc/dtb_platdata.py @@ -46,6 +46,9 @@ VAL_PREFIX = 'dtv_' def conv_name_to_c(name): """Convert a device-tree name to a C identifier + This uses multiple replace() calls instead of re.sub() since it is faster + (400ms for 1m calls versus 1000ms for the 're' version). + Args: name: Name to convert Return: