From: Denis Vlasenko <vda.linux@googlemail.com>
Date: Tue, 29 Jul 2008 00:00:14 +0000 (-0000)
Subject: libbb: dump: do not use uninitialized memory. close bug 4364.
X-Git-Tag: 1_12_0~72
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=2f86d13dff6f2a5d4b8ac9350d306ca119a7e0e8;p=oweals%2Fbusybox.git

libbb: dump: do not use uninitialized memory. close bug 4364.
---

diff --git a/libbb/dump.c b/libbb/dump.c
index 0d553d4d0..74c5e1691 100644
--- a/libbb/dump.c
+++ b/libbb/dump.c
@@ -376,17 +376,16 @@ static unsigned char *get(priv_dumper_t *dumper)
 {
 	int n;
 	int need, nread;
-	unsigned char *tmpp;
 	int blocksize = dumper->blocksize;
 
 	if (!dumper->get__curp) {
 		dumper->address = (off_t)0; /*DBU:[dave@cray.com] initialize,initialize..*/
 		dumper->get__curp = xmalloc(blocksize);
-		dumper->get__savp = xmalloc(blocksize);
+		dumper->get__savp = xzalloc(blocksize); /* need to be initialized */
 	} else {
-		tmpp = dumper->get__curp;
+		unsigned char *tmp = dumper->get__curp;
 		dumper->get__curp = dumper->get__savp;
-		dumper->get__savp = tmpp;
+		dumper->get__savp = tmp;
 		dumper->savaddress += blocksize;
 		dumper->address = dumper->savaddress;
 	}