From: Luis Cáceres <lacaceres97@gmail.com>
Date: Wed, 6 Dec 2017 16:32:05 +0000 (+0000)
Subject: Ensure no item stack is being held before crafting (#4779)
X-Git-Tag: 5.0.0~696
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=2b5341c51864660bb1a434a520f7cca9ce3619e6;p=oweals%2Fminetest.git

Ensure no item stack is being held before crafting (#4779)
---

diff --git a/src/gui/guiFormSpecMenu.cpp b/src/gui/guiFormSpecMenu.cpp
index 0691bc598..c83e6aa49 100644
--- a/src/gui/guiFormSpecMenu.cpp
+++ b/src/gui/guiFormSpecMenu.cpp
@@ -3668,18 +3668,24 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 			a->from_i = m_selected_item->i;
 			m_invmgr->inventoryAction(a);
 		} else if (craft_amount > 0) {
-			m_selected_content_guess = ItemStack(); // Clear
-
-			// Send IAction::Craft
-
 			assert(s.isValid());
-			assert(inv_s);
-
-			infostream << "Handing IAction::Craft to manager" << std::endl;
-			ICraftAction *a = new ICraftAction();
-			a->count = craft_amount;
-			a->craft_inv = s.inventoryloc;
-			m_invmgr->inventoryAction(a);
+			
+			// if there are no items selected or the selected item
+			// belongs to craftresult list, proceed with crafting
+			if (m_selected_item == NULL ||
+					!m_selected_item->isValid() || m_selected_item->listname == "craftresult") {
+				
+				m_selected_content_guess = ItemStack(); // Clear
+				
+				assert(inv_s);
+
+				// Send IACTION_CRAFT
+				infostream << "Handing IACTION_CRAFT to manager" << std::endl;
+				ICraftAction *a = new ICraftAction();
+				a->count = craft_amount;
+				a->craft_inv = s.inventoryloc;
+				m_invmgr->inventoryAction(a);
+			}
 		}
 
 		// If m_selected_amount has been decreased to zero, deselect