From: Rob Landley Date: Fri, 4 Aug 2006 19:16:31 +0000 (-0000) Subject: Now that we have xopen3(), it's just plain unclean to have xopen() with X-Git-Tag: 1_4_0~827 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=27d07c9ce2f07cf85116455e356ba6c4b57f86fe;p=oweals%2Fbusybox.git Now that we have xopen3(), it's just plain unclean to have xopen() with O_CREAT. Two users are still doing it (and thus getting permissions 777), I'm not sure what permissions they should be using but here they are changed to xopen3(). This costs us a dozen or so bytes, but removing the 777 from xopen() should get some of that back. --- diff --git a/archival/unzip.c b/archival/unzip.c index 68083e987..2585cbf3f 100644 --- a/archival/unzip.c +++ b/archival/unzip.c @@ -333,7 +333,7 @@ int unzip_main(int argc, char **argv) overwrite = o_always; case 'y': /* Open file and fall into unzip */ unzip_create_leading_dirs(dst_fn); - dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT); + dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT, 777); case -1: /* Unzip */ if (verbosity == v_normal) { printf(" inflating: %s\n", dst_fn); diff --git a/networking/ftpgetput.c b/networking/ftpgetput.c index 767ace9fb..978601d26 100644 --- a/networking/ftpgetput.c +++ b/networking/ftpgetput.c @@ -166,7 +166,7 @@ static int ftp_receive(ftp_host_info_t *server, FILE *control_stream, if (do_continue) { fd_local = xopen(local_path, O_APPEND | O_WRONLY); } else { - fd_local = xopen(local_path, O_CREAT | O_TRUNC | O_WRONLY); + fd_local = xopen3(local_path, O_CREAT | O_TRUNC | O_WRONLY, 777); } }