From: John Beppu <beppu@lbox.org>
Date: Tue, 27 Jun 2000 04:56:45 +0000 (-0000)
Subject: + littering my code w/ comments about what troubles me.
X-Git-Tag: 0_46~89
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=27b5924b96fc71a6f70ea1a13a5232fca2439e7d;p=oweals%2Fbusybox.git

+ littering my code w/ comments about what troubles me.
---

diff --git a/applets/busybox.c b/applets/busybox.c
index 78f07e338..5f1c56bc3 100644
--- a/applets/busybox.c
+++ b/applets/busybox.c
@@ -420,10 +420,15 @@ int main(int argc, char **argv)
 	const struct BB_applet	*a		= applets;
 
 #ifdef BB_FEATURE_INSTALLER	
+	/* 
+	 * This style of argument parsing doesn't scale well 
+	 * in the event that busybox starts wanting more --options.
+	 * If someone has a cleaner approach, by all means implement it.
+	 */
 	if (argc > 1 && (strcmp(argv[1], "--install") == 0)) {
 		int use_symbolic_links = 0;
 
-		/* to use symlinks, or to not use symlinks... */
+		/* to use symlinks, or not to use symlinks... */
 		if (argc > 2) {
 			if ((strcmp(argv[2], "-s") == 0)) { 
 				use_symbolic_links = 1; 
diff --git a/busybox.c b/busybox.c
index 78f07e338..5f1c56bc3 100644
--- a/busybox.c
+++ b/busybox.c
@@ -420,10 +420,15 @@ int main(int argc, char **argv)
 	const struct BB_applet	*a		= applets;
 
 #ifdef BB_FEATURE_INSTALLER	
+	/* 
+	 * This style of argument parsing doesn't scale well 
+	 * in the event that busybox starts wanting more --options.
+	 * If someone has a cleaner approach, by all means implement it.
+	 */
 	if (argc > 1 && (strcmp(argv[1], "--install") == 0)) {
 		int use_symbolic_links = 0;
 
-		/* to use symlinks, or to not use symlinks... */
+		/* to use symlinks, or not to use symlinks... */
 		if (argc > 2) {
 			if ((strcmp(argv[2], "-s") == 0)) { 
 				use_symbolic_links = 1;