From: Matt Caswell <matt@openssl.org>
Date: Tue, 17 May 2016 10:07:27 +0000 (+0100)
Subject: Remove repeated condition from if in X509_NAME_oneline
X-Git-Tag: OpenSSL_1_1_0-pre6~812
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=2647e2617e31002cb0ab80758be4e566917d2888;p=oweals%2Fopenssl.git

Remove repeated condition from if in X509_NAME_oneline

An if checks the value of |type| to see if it is V_ASN1_VISIBLESTRING
twice. We only need to do it once.

GitHub Issue #656

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/crypto/x509/x509_obj.c b/crypto/x509/x509_obj.c
index eaa03f2b88..1297307462 100644
--- a/crypto/x509/x509_obj.c
+++ b/crypto/x509/x509_obj.c
@@ -129,7 +129,7 @@ char *X509_NAME_oneline(X509_NAME *a, char *buf, int len)
             type == V_ASN1_VISIBLESTRING ||
             type == V_ASN1_PRINTABLESTRING ||
             type == V_ASN1_TELETEXSTRING ||
-            type == V_ASN1_VISIBLESTRING || type == V_ASN1_IA5STRING) {
+            type == V_ASN1_IA5STRING) {
             if (num > (int)sizeof(ebcdic_buf))
                 num = sizeof(ebcdic_buf);
             ascii2ebcdic(ebcdic_buf, q, num);