From: kwolekr <kwolekr@minetest.net>
Date: Wed, 25 Dec 2013 04:50:49 +0000 (-0500)
Subject: Fix exception caused by destroying sockets on Server shutdown
X-Git-Tag: 0.4.9~1
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=25b1cca4150a9f78b05b98afee71a97fd052df71;p=oweals%2Fminetest.git

Fix exception caused by destroying sockets on Server shutdown
---

diff --git a/src/socket.cpp b/src/socket.cpp
index c3873dab6..78ff364e5 100644
--- a/src/socket.cpp
+++ b/src/socket.cpp
@@ -546,7 +546,10 @@ bool UDPSocket::WaitData(int timeout_ms)
 
 	if(result == 0)
 		return false;
-	else if(result < 0 && errno == EINTR)
+	else if(result < 0 && (errno == EINTR || errno == EBADF))
+		// N.B. select() fails when sockets are destroyed on Connection's dtor
+		// with EBADF.  Instead of doing tricky synchronization, allow this
+		// thread to exit but don't throw an exception.
 		return false;
 	else if(result < 0)
 	{
@@ -557,9 +560,9 @@ bool UDPSocket::WaitData(int timeout_ms)
 		int e = WSAGetLastError();
 		dstream << (int) m_handle << ": WSAGetLastError()="
 		        << e << std::endl;
-		if(e == 10004 /* = WSAEINTR */)
+		if(e == 10004 /* = WSAEINTR */ || e == 10009 /*WSAEBADF*/)
 		{
-			dstream << "WARNING: Ignoring WSAEINTR." << std::endl;
+			dstream << "WARNING: Ignoring WSAEINTR/WSAEBADF." << std::endl;
 			return false;
 		}
 #endif