From: Jo-Philipp Wich <jo@mein.io>
Date: Thu, 22 Nov 2018 13:47:56 +0000 (+0100)
Subject: luci-base: do not trigger form action when revealing password
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=241b90c7f66dd08bca4ff89ea7cfe8aed9823bdd;p=oweals%2Fluci.git

luci-base: do not trigger form action when revealing password

Ref: https://github.com/openwrt/luci/issues/2327
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
---

diff --git a/modules/luci-base/luasrc/view/cbi/value.htm b/modules/luci-base/luasrc/view/cbi/value.htm
index 79a358b30..27f3cb2bd 100644
--- a/modules/luci-base/luasrc/view/cbi/value.htm
+++ b/modules/luci-base/luasrc/view/cbi/value.htm
@@ -21,6 +21,6 @@
 		ifattr(#self.keylist > 0, "data-choices", { self.keylist, self.vallist })
 	%> />
 	<%- if self.password then -%>
-		<button class="cbi-button cbi-button-neutral" title="<%:Reveal/hide password%>" aria-label="<%:Reveal/hide password%>" onclick="var e = this.previousElementSibling; e.type = (e.type === 'password') ? 'text' : 'password'">∗</button>
+		<button class="cbi-button cbi-button-neutral" title="<%:Reveal/hide password%>" aria-label="<%:Reveal/hide password%>" onclick="var e = this.previousElementSibling; e.type = (e.type === 'password') ? 'text' : 'password'; event.preventDefault()">∗</button>
 	<% end %>
 <%+cbi/valuefooter%>