From: Matt Caswell <matt@openssl.org>
Date: Mon, 23 Apr 2018 08:01:49 +0000 (+0100)
Subject: Remove some logically dead code
X-Git-Tag: OpenSSL_1_1_1-pre6~40
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=22eb2d1c80ff511985c0b32a6f4699c3a062311b;p=oweals%2Fopenssl.git

Remove some logically dead code

This dead code should have been removed as part of #5874 but got missed.

Found by Coverity.

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/6049)
---

diff --git a/ssl/statem/statem_lib.c b/ssl/statem/statem_lib.c
index 6d0778db3f..269ba85997 100644
--- a/ssl/statem/statem_lib.c
+++ b/ssl/statem/statem_lib.c
@@ -1073,9 +1073,6 @@ WORK_STATE tls_finish_handshake(SSL *s, WORK_STATE wst, int clearbufs, int stop)
                               &discard, s->session_ctx->lock);
         }
 
-        if (cb != NULL)
-            cb(s, SSL_CB_HANDSHAKE_DONE, 1);
-
         if (SSL_IS_DTLS(s)) {
             /* done with handshaking */
             s->d1->handshake_read_seq = 0;