From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Tue, 19 Mar 2019 17:44:05 +0000 (+0100)
Subject: efi_loader: memory leak in efi_dump_single_var()
X-Git-Tag: v2019.04~24^2~3
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=1fd7a4764103781e424ef687034da06de3cb60b7;p=oweals%2Fu-boot.git

efi_loader: memory leak in efi_dump_single_var()

A misplaced return statement lead to a memory leak in
efi_dump_single_var().

Reported-by: Coverity (CID 185829)
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/cmd/nvedit_efi.c b/cmd/nvedit_efi.c
index ca32566a61..e65b38dbf3 100644
--- a/cmd/nvedit_efi.c
+++ b/cmd/nvedit_efi.c
@@ -80,7 +80,6 @@ static void efi_dump_single_var(u16 *name, efi_guid_t *guid)
 	printf(", DataSize = 0x%zx\n", size);
 	print_hex_dump("    ", DUMP_PREFIX_OFFSET, 16, 1, data, size, true);
 
-	return;
 out:
 	free(data);
 }