From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sat, 15 Jun 2019 10:58:30 +0000 (+0200)
Subject: efi_loader: SetMode() parameters check
X-Git-Tag: v2019.07~20^2~13
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=1f7a8b3389d66f279bf75fcfdd10c1c7d2561d6e;p=oweals%2Fu-boot.git

efi_loader: SetMode() parameters check

If EFI_GRAPHICS_OUTPUT_PROTOCOL.SetMode() is called with an invalid mode,
return EFI_UNSUPPORTED.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c
index c44a1cfc47..676463f2de 100644
--- a/lib/efi_loader/efi_gop.c
+++ b/lib/efi_loader/efi_gop.c
@@ -60,12 +60,14 @@ out:
 
 static efi_status_t EFIAPI gop_set_mode(struct efi_gop *this, u32 mode_number)
 {
+	efi_status_t ret = EFI_SUCCESS;
+
 	EFI_ENTRY("%p, %x", this, mode_number);
 
-	if (mode_number != 0)
-		return EFI_EXIT(EFI_INVALID_PARAMETER);
+	if (mode_number)
+		ret = EFI_UNSUPPORTED;
 
-	return EFI_EXIT(EFI_SUCCESS);
+	return EFI_EXIT(ret);
 }
 
 static __always_inline struct efi_gop_pixel efi_vid16_to_blt_col(u16 vid)